-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API Server Service Information to KarmadaStatus
#5775
Add API Server Service Information to KarmadaStatus
#5775
Conversation
Signed-off-by: Joe Nathan Abellard <contact@jabellard.com>
7d23514
to
325e3bd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5775 +/- ##
==========================================
+ Coverage 42.30% 42.31% +0.01%
==========================================
Files 655 655
Lines 55756 55759 +3
==========================================
+ Hits 23589 23597 +8
+ Misses 30653 30649 -4
+ Partials 1514 1513 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This is an implementation of this proposal for adding information about the API Server service of a Karmada instance to its status.
Which issue(s) this PR fixes:
Fixes #5567
Part of #5767
Special notes for your reviewer:
Does this PR introduce a user-facing change?: