Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API Server Service Information to KarmadaStatus #5775

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

jabellard
Copy link
Contributor

@jabellard jabellard commented Nov 2, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:
This is an implementation of this proposal for adding information about the API Server service of a Karmada instance to its status.

Which issue(s) this PR fixes:
Fixes #5567
Part of #5767
Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The new `ApiServerService` field added as part of the Karmada instance status can be used to reference the API Server service for that instance. This is useful for scenarios where higher level operators need to discover the API Server service of a Karmada instance  for tasks like setting up ingress traffic.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 2, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 2, 2024
@jabellard
Copy link
Contributor Author

@RainbowMango

Signed-off-by: Joe Nathan Abellard <contact@jabellard.com>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.31%. Comparing base (5cd3c1a) to head (325e3bd).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5775      +/-   ##
==========================================
+ Coverage   42.30%   42.31%   +0.01%     
==========================================
  Files         655      655              
  Lines       55756    55759       +3     
==========================================
+ Hits        23589    23597       +8     
+ Misses      30653    30649       -4     
+ Partials     1514     1513       -1     
Flag Coverage Δ
unittests 42.31% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@karmada-bot karmada-bot merged commit 01b8312 into karmada-io:master Nov 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add API Server Service Info to Karmada Status
4 participants