Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/karmadactl: unit test apply command #5785

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we unit test apply command on validation, and generating propagation objects.

What type of PR is this?

Which issue(s) this PR fixes:
Part of #5491.

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.67%. Comparing base (8c7607e) to head (982ff71).
Report is 45 commits behind head on master.

Files with missing lines Patch % Lines
pkg/karmadactl/apply/apply.go 33.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5785      +/-   ##
==========================================
+ Coverage   42.29%   45.67%   +3.37%     
==========================================
  Files         655      658       +3     
  Lines       55851    53926    -1925     
==========================================
+ Hits        23622    24630    +1008     
+ Misses      30716    27689    -3027     
- Partials     1513     1607      +94     
Flag Coverage Δ
unittests 45.67% <33.33%> (+3.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

Hi @mohamedawnallah, the ci lint is failed, can you help fix it?

@mohamedawnallah mohamedawnallah force-pushed the unitTestApplyKarmadactlCommand branch from 22f8199 to d5469d5 Compare November 11, 2024 17:24
@mohamedawnallah
Copy link
Contributor Author

@XiShanYongYe-Chang all test cases passed now :)

@XiShanYongYe-Chang
Copy link
Member

Thanks @mohamedawnallah
/assign

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other parts LGTM

In this commit, we unit test apply command on validation,
and generating propagation objects.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
@mohamedawnallah mohamedawnallah force-pushed the unitTestApplyKarmadactlCommand branch from d5469d5 to 982ff71 Compare November 17, 2024 03:17
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from xishanyongye-chang. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants