-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/karmadactl: unit test apply command #5785
base: master
Are you sure you want to change the base?
pkg/karmadactl: unit test apply command #5785
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5785 +/- ##
==========================================
+ Coverage 42.29% 45.67% +3.37%
==========================================
Files 655 658 +3
Lines 55851 53926 -1925
==========================================
+ Hits 23622 24630 +1008
+ Misses 30716 27689 -3027
- Partials 1513 1607 +94
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @mohamedawnallah, the ci lint is failed, can you help fix it? |
22f8199
to
d5469d5
Compare
@XiShanYongYe-Chang all test cases passed now :) |
Thanks @mohamedawnallah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other parts LGTM
In this commit, we unit test apply command on validation, and generating propagation objects. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
d5469d5
to
982ff71
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we unit test apply command on validation, and generating propagation objects.
What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491.
Does this PR introduce a user-facing change?: