-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced descheduler leaderElection options including: --leader-elect-lease-duration
, --leader-elect-renew-deadline
, --leader-elect-retry-period
,
#5787
Conversation
Signed-off-by: huangyanfeng <huangyanfeng1992@gmail.com>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5787 +/- ##
==========================================
+ Coverage 34.14% 42.32% +8.17%
==========================================
Files 643 656 +13
Lines 44522 55883 +11361
==========================================
+ Hits 15204 23653 +8449
- Misses 28162 30712 +2550
- Partials 1156 1518 +362
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch looks good to me.
Just noticed that this PR is based on the commit made nearly 2 months ago.
I'm curious why the following tests would be launched:
- Operator / Test on Kubernetes (v1.30.0) (pull_request)
- Operator / Test on Kubernetes (v1.31.0) (pull_request)
- Operator / Test on Kubernetes (v1.29.0) (pull_request)
Given the tests against the PR, the tests-related work isn't included in this PR.
cc @zhzhuang-zju
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at 593c2cc19 Merge 5dd6abafb9de5605aebadde7406c4c781d426fb4 into ac589d6921d73136cc869e326ed8107ce5c990d7 https://github.com/karmada-io/karmada/actions/runs/11679088238/job/32519589508?pr=5787 When checking out the logs, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: huangyanfeng huangyanfeng1992@gmail.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
descheduler add LeaderElection config
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: