Merge pull request #7 from solverat/ignore_captured_error

Do not track TRANSACTION_ALREADY_CAPTURED Error
karser · Nov 10, 2020 · 9e9d192 · 9e9d192
2 parents 5a3c202 + 73e849b
commit 9e9d192
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/Action/Api/CaptureTransactionAction.php b/Action/Api/CaptureTransactionAction.php
@@ -34,8 +34,13 @@ public function execute($request)
                 'Date' => $response['Date'],
             ])]);
         } catch (SaferpayHttpException $e) {
-            $model['Error'] = $e->toArray();
-            $model->replace(['Transaction' => array_merge($model['Transaction'], ['Status' => Constants::STATUS_FAILED])]);
+            $error = $e->toArray();
+            $errorName = $error['Data']['ErrorName'] ?? null;
+            // do not raise any errors if transaction already has been captured
+            if ($errorName !== Constants::ERROR_NAME_TRANSACTION_ALREADY_CAPTURED) {
+                $model['Error'] = $error;
+                $model->replace(['Transaction' => array_merge($model['Transaction'], ['Status' => Constants::STATUS_FAILED])]);
+            }
         }
     }
 

diff --git a/Constants.php b/Constants.php
@@ -29,4 +29,6 @@ interface Constants
 
     const LS_IF_ALLOWED_BY_SCHEME = 'IF_ALLOWED_BY_SCHEME';
     const LS_WITH_LIABILITY_SHIFT = 'WITH_LIABILITY_SHIFT';
+
+    const ERROR_NAME_TRANSACTION_ALREADY_CAPTURED = 'TRANSACTION_ALREADY_CAPTURED';
 }