Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo page broken #14

Open
letmaik opened this issue Jul 6, 2015 · 6 comments
Open

Demo page broken #14

letmaik opened this issue Jul 6, 2015 · 6 comments

Comments

@letmaik
Copy link

letmaik commented Jul 6, 2015

Tested with latest Firefox.

@perliedman
Copy link
Contributor

Which version is that, and on which platform?

Just tried it on Firefox 38/Linux Ubuntu 14.04, and it seems to work as expected.

@letmaik
Copy link
Author

letmaik commented Jul 6, 2015

Sorry, I found out it's only broken when I access it via https (to which
the HTTPS Everywhere browser extension switches to automatically):
https://kartena.github.io/Leaflet.Pancontrol/

On 06/07/2015 14:06, Per Liedman wrote:

Which version is that, and on which platform?

Just tried it on Firefox 38/Linux Ubuntu 14.04, and it seems to work
as expected.


Reply to this email directly or view it on GitHub
#14 (comment).

simison added a commit to simison/Leaflet.Pancontrol that referenced this issue Jul 6, 2015
LeafletJS [instructs](http://leafletjs.com/download.html) to use CloudFlare CDN directly.

Fixes kartena#14
@perliedman
Copy link
Contributor

Yeah, the page loads the Leaflet JS and CSS from http, which is blocked if the page is loaded with https; I guess we could switch to using protocol relative URLs for loading them.

@simison
Copy link
Contributor

simison commented Jul 8, 2015

@perliedman see #15 ;-) Does just that.

@perliedman
Copy link
Contributor

#15 fixes the demo page, but not the gh-pages branch, so the public demo is still broken. Easy to fix, but since I'm on vacation and with a very limited connection, I will let it be for now.

@perliedman perliedman reopened this Jul 8, 2015
@timwaters
Copy link

I see it has been merged now.

It would be great to change the About website link to: https://kartena.github.io/Leaflet.Pancontrol/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants