Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat validate upload #211

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Feat validate upload #211

merged 5 commits into from
Jan 24, 2025

Conversation

danangmassandy
Copy link
Contributor

@danangmassandy danangmassandy commented Dec 31, 2024

This is for #116.

@danangmassandy danangmassandy marked this pull request as ready for review December 31, 2024 10:26
Copy link
Member

@dimasciput dimasciput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you think it's better to move the fiona util class to cloudnativegis?

@dimasciput
Copy link
Member

@danangmassandy

@danangmassandy
Copy link
Contributor Author

Yeah, I think that will be useful in cloud native gis too. I will move it there and update this PR.

@danangmassandy
Copy link
Contributor Author

@dimasciput I have submitted a PR in CloudNativeGIS to move the fiona utilities.

kartoza/CloudNativeGIS#21

@dimasciput
Copy link
Member

@danangmassandy thanks, I have merged it, could you update your PR here?

@mvmaltitz mvmaltitz linked an issue Jan 22, 2025 that may be closed by this pull request
@danangmassandy danangmassandy merged commit 4caee1e into main Jan 24, 2025
2 checks passed
@danangmassandy danangmassandy deleted the feat-validate-upload branch January 24, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Upload: Dataset Validation
2 participants