TB-59 Aggregerte registeringer på bruksenhet og bygning #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
kvstrant
reviewed
Sep 13, 2024
src/main/kotlin/no/kartverket/matrikkel/bygning/models/Bygning.kt
Outdated
Show resolved
Hide resolved
kvstrant
reviewed
Sep 16, 2024
src/main/kotlin/no/kartverket/matrikkel/bygning/models/BygningExtensions.kt
Outdated
Show resolved
Hide resolved
kvstrant
approved these changes
Sep 16, 2024
|
@kvstrant Enig. Tenker det hadde vært fint å være alle 3 rundt det å lage en god "base"-struktur på alle feltene som registreres, litt som jeg var inne på på slack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EgenregistreringJeg er ikke helt sikker på om bruksenhetaggregeringen trenger å være så "smart" som den er med filtrering og å sette opp et pair, sånn som jeg har kommentert.
NB: Hvis man nå registrerer på liste-registreringene (Oppvarming og Energikilder), så vil hele registreringen få nytt registreringstidspunkt, det går ikke individuelt per felt