Add part-way compatibility with Fixtures #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still not quite sure about this, and I'm wondering if we should just lean more on converters like in #22 to help upgrade people instead. |
kaspth
commented
Aug 19, 2023
| @@ -0,0 +1,3 @@ | |||
| first: | |||
| name: "YAML" | |||
| account: business | |||
There was a problem hiding this comment.
Swapping to FixtureSet.identify above means that we can safely refer to the account created with accounts.update :business in here and get it connected.
Uses `FixtureSet.identify` to have the same logic as the primary key generation that fixtures use, in that way we're a drop in replacement that could potentially be used alongside fixtures. Since Fixtures issues a DELETE FROM for every table that's loaded with it, I'm opting to not support loading with Oaken and Fixtures on the same table. E.g. using both `test/seeds.rb` (or `test/seeds/users.rb`) with `users.update` and `test/fixtures/users.yml` aren't supported. Otherwise we'd need to override `setup_fixtures` which will have started transactions on the database connection already, so any data we create is rolled back after the test, and we'd need probably complex connection management to handle that.
kaspth
force-pushed
the
fixtures-compatiblity
branch
from
5e104e6
to
25c8207
Compare
|
I can't figure out if this is what we want, but it's not gonna get clearer unless we try it out. So I'm going to go with this and then we'll see what changes we need, if any. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
FixtureSet.identifyto have the same logic as the primary key generation that fixtures use, in that way we're a drop in replacement that could potentially be used alongside fixtures.Since Fixtures issues a DELETE FROM for every table that's loaded with it, I'm opting to not support loading with Oaken and Fixtures on the same table.
E.g. using both
test/seeds.rb(ortest/seeds/users.rb) withusers.updateandtest/fixtures/users.ymlaren't supported. Otherwise we'd need to overridesetup_fixtureswhich will have started transactions on the database connection already, so any data we create is rolled back after the test, and we'd need probably complex connection management to handle that.