Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate search entries #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fwiesel
Copy link

@fwiesel fwiesel commented Mar 11, 2022

More a stilistic nicety. If we get a search suffix passed,
which is already part of the local configuration, it will
be duplicated. The change avoids that

Copy link
Owner

@kayrus kayrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies for late response. see my comments.

pkg/link/link.go Outdated Show resolved Hide resolved
@fwiesel fwiesel force-pushed the remove_duplicate_search branch from 6934ac9 to 46e3417 Compare March 28, 2022 12:51
@fwiesel fwiesel requested a review from kayrus March 28, 2022 12:53
pkg/link/link.go Outdated Show resolved Hide resolved
More a stilistic nicety. If we get a search suffix passed,
which is already part of the local configuration, it will
be duplicated. The change avoids that
@fwiesel fwiesel force-pushed the remove_duplicate_search branch from 46e3417 to d5bea10 Compare March 28, 2022 14:51
@fwiesel fwiesel requested a review from kayrus March 28, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants