Fix margins #28
Merged
Fix margins #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kba
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
Thanks, this is much clearer and more importantly, looks correct :) I am still learning new things about ALTO/PAGE printspace/border
| # ║└───┘ ║ ╔═══════╗ ║║ ║ ║ └───┘ | ||
| # ║ ║ ║ ║ ║║ ║ ║ | ||
| # ╚═══════╝ ╚═══════╝ ╚╝ ╚══╝ | ||
| # |
There was a problem hiding this comment.
Unfortunately, PRImA libs do not handle ALTO that way:
(They ignore Border and treat the margins as anything beyond the PrintSpace.)
| @@ -49,3 +49,18 @@ def get_nth_textequiv(reg_page, textequiv_index, textequiv_fallback_strategy): | |||
| else: | |||
| return textequivs[textequiv_index].Unicode | |||
|
|
|||
| def contains(el, bbox): | |||
There was a problem hiding this comment.
If we move forward with ALTO support in core this might be a useful addition to ocrds_utils.
bertsky
commented
Jan 31, 2022
bertsky
commented
Jan 31, 2022
bertsky
commented
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.