-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export from_str_header and csv_heade macros #22
Conversation
Hey, Before these macros can be made public we must ensure they don't use any relative import paths. The The macros would need to be changed to address this. e.g. every |
Thanks for your answer! That's right, I missed that. I'll try to make the changes and then you can look over it again? |
I think that fits now. What do you think? @kbalt |
The macro changes look good, but you've introduced a lot of formatting changes to imports and |
I removed the formatting, Should be ready now, please check again. :) |
Thanks! |
Hi,
another small improvement would be to export the two macros
from_str_header
andcsv_header
.Then someone can easily use them to create custom headers like this:
What do you think about this?