Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#13] Throw error when allowed origins are not configured #14

Merged
merged 2 commits into from
Nov 28, 2023
Merged

[#13] Throw error when allowed origins are not configured #14

merged 2 commits into from
Nov 28, 2023

Conversation

blcham
Copy link

@blcham blcham commented Nov 22, 2023 •
edited
Loading

Resolves #13

@blcham blcham requested a review from ledsoft November 22, 2023 23:08
@blcham blcham force-pushed the fix-case-when-allowed-origins-are-not-configured branch from f893d77 to c653f33 Compare November 22, 2023 23:18
@blcham blcham removed the request for review from ledsoft November 22, 2023 23:33
@blcham
Copy link
Author

blcham commented Nov 22, 2023

@blcham WIP, need to check the default setting (when NO CORS needed)

@blcham blcham mentioned this pull request Nov 23, 2023
Closed
@blcham blcham force-pushed the fix-case-when-allowed-origins-are-not-configured branch from c653f33 to 79532ef Compare November 28, 2023 21:33
@blcham blcham force-pushed the fix-case-when-allowed-origins-are-not-configured branch from 79532ef to 57b4dac Compare November 28, 2023 21:34
@blcham blcham merged commit 931410c into main Nov 28, 2023
2 checks passed
@blcham blcham deleted the fix-case-when-allowed-origins-are-not-configured branch November 28, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configuration with no allowed origin sets allow credentials to true
1 participant
@blcham