Prevent accidental update of user types when referencing current user #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes when referencing current user.
blcham
requested changes
Dec 5, 2023
Co-authored-by: Miroslav Blaško <blcham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should prevent kbss-cvut/record-manager-ui#23, which was likely caused by using the currently logged in user (which is retrieved from the repository) in a transaction. If the current user was impersonated, a special type is added to it, and if this happens in a transaction, this update is written to the repository.
The fix lies in using a copy of the retrieved user instance that is detached from the persistence context.