Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/33 admin setting user institution in keycloack deployment #34

Conversation

kostobog
Copy link

@kostobog kostobog commented Dec 12, 2023

Only the last commit (3c6ac92) updating UserController is relevant. The other commits are from PR #31.

@kostobog kostobog requested a review from blcham December 12, 2023 17:56
@kostobog
Copy link
Author

@blcham Is this solution ok?

Copy link

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment and that tests are failing.

@kostobog kostobog closed this Dec 13, 2023
@blcham
Copy link

blcham commented Dec 13, 2023

Closing PR as @kostobog created a new PR #35 adding updateUserInstitution to OidcUserController. Tests pass in PR #35.

@blcham blcham deleted the issues/33-admin-setting-user-institution-in-keycloack-deployment branch December 17, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants