Issues/33 set user institution in keycloack deployment #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blcham
requested changes
Dec 13, 2023
blcham
requested changes
Dec 13, 2023
…o OidcUserController.updateUser
- remove validation check if old and new institutions are the same - use variable "original" to update the institution - log trace level message about the update only if old and new institutions are different - add method to check if HasUri entities are equal by URI - add method to get the URI of HasUri entity
kostobog
force-pushed
the
issues/33-set-user-institution-in-keycloack-deployment
branch
from
3402342
to
29181f7
Compare
blcham
approved these changes
Dec 13, 2023
blcham
deleted the
issues/33-set-user-institution-in-keycloack-deployment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #33
Only the last commit 64cfe2c is relevant, see file changes in file
OidcUserController. The other commits are from PR #31.