Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store records in their own repository contexts #6

Merged
merged 16 commits into from
Nov 19, 2023
Merged

Conversation

ledsoft
Copy link

@ledsoft ledsoft commented Nov 2, 2023

Implements kbss-cvut/23ava-distribution#10

Note that these changes are not compatible with existing data.

ledsoft and others added 5 commits November 2, 2023 09:06
…generated by DAO instead of JOPA.

This allows knowing the identifier before persist.
…ding to their identifiers.

The record identifier is now based on its key, so that they can be derived from each other.
@ledsoft ledsoft requested a review from blcham November 2, 2023 11:08
ledsoft and others added 5 commits November 8, 2023 16:55
The configuration includes automatic repository creation.
This ensures only known roles are mapped, and they are mapped correctly to types used by the record manager.
Also add setup guide for the Docker Compose deployment.
@ledsoft
Copy link
Author

ledsoft commented Nov 13, 2023

Since this PR has not been merged, yet, the new changes implementing kbss-cvut/23ava-distribution#11 have been automatically added to it.

@ledsoft
Copy link
Author

ledsoft commented Nov 13, 2023

Also I noticed that there is a draft of a ticket for migrating Record Manager from RDF4J to GraphDB. The Docker Compose setup I created uses GraphDB, so maybe that ticket can be closed as well.

Copy link

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor suggestions.

db-server/repo-config/config-record-manager.ttl Outdated Show resolved Hide resolved
db-server/repo-init.sh Outdated Show resolved Hide resolved
db-server/repo-config/config-record-manager-formgen.ttl Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
db-server/repo-config/config-record-manager.ttl Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@blcham blcham self-requested a review November 19, 2023 12:16
ledsoft and others added 6 commits November 19, 2023 15:11
Co-authored-by: Miroslav Blaško <blcham@gmail.com>
Co-authored-by: Miroslav Blaško <blcham@gmail.com>
Co-authored-by: Miroslav Blaško <blcham@gmail.com>
Co-authored-by: Miroslav Blaško <blcham@gmail.com>
Co-authored-by: Miroslav Blaško <blcham@gmail.com>
Co-authored-by: Miroslav Blaško <blcham@gmail.com>
@blcham blcham merged commit 18ba3f2 into kbss-cvut:main Nov 19, 2023
1 of 2 checks passed
blcham added a commit to kbss-cvut/record-manager-ui that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants