Design fine-grained access control within record manager #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palagdan
force-pushed
the
202-fine-grained
branch
from
49748c2
to
068949e
Compare
|
Sorry, we did not understand each other. To me the ontology is one of most important artefact of SW and thus i want to keep ontology conventions i.e. "-" instead of "_" -- which was broken by your last commit. |
|
@blcham I noticed that some properties don't follow the convention. Should I update them as well in the current ticket? Such as: public final static String s_p_has_object_value = "http://onto.fel.cvut.cz/ontologies/documentation/has_object_value";
public final static String s_p_has_related_question = "http://onto.fel.cvut.cz/ontologies/documentation/has_related_question"; |
palagdan
force-pushed
the
202-fine-grained
branch
from
bb9f1d8
to
068949e
Compare
blcham
requested changes
Sep 12, 2024
palagdan
force-pushed
the
202-fine-grained
branch
4 times, most recently
from
5c84bf4
to
fc33cc1
Compare
blcham
requested changes
Sep 17, 2024
| public static final String ROLE_ADMIN = "ROLE_ADMIN"; | ||
| public static final String ROLE_COMPLETE_RECORDS = "rm_complete_records"; |
There was a problem hiding this comment.
Why do we need those constants? Why Role enum is not enough for this case? (same way as we discussed in frontend)
| @@ -7,8 +7,19 @@ | |||
| import java.util.stream.Stream; | |||
|
|
|||
| public enum Role { | |||
| USER(SecurityConstants.ROLE_USER, Vocabulary.s_c_doctor), | |||
| ADMIN(SecurityConstants.ROLE_ADMIN, Vocabulary.s_c_administrator); | |||
| USER(SecurityConstants.ROLE_USER, Vocabulary.s_i_user), | |||
There was a problem hiding this comment.
Why we are duplicating again study/model/Role.java ? Why cant we reuse it ?
| @@ -143,6 +142,7 @@ public static User generateUser(Institution institution){ | |||
| person.setLastName("RandomLastName" + randomInt()); | |||
| person.setEmailAddress("RandomEmail" + randomInt() + "@random.rand"); | |||
| person.setInstitution(institution); | |||
| person.setRoleGroup(Vocabulary.s_i_operator_admin_role_group); | |||
|
|
||
| assertEquals(2, numberOfInvestigators); | ||
| } | ||
| // @Test |
| @@ -49,10 +49,10 @@ void attemptSwitchUserSwitchesCurrentUserToTarget() { | |||
| @Test | |||
| void attemptSwitchUserThrowsBadRequestExceptionWhenTargetUserIsAdmin() { | |||
| final User source = Generator.generateUser(null); | |||
| source.addType(Vocabulary.s_c_administrator); | |||
| source.addType(Vocabulary.s_i_administrator); | |||
There was a problem hiding this comment.
We are mixing two approaches here how to associate user with role group/roles
| @@ -66,6 +68,7 @@ public void setUp() { | |||
| Institution institution = Generator.generateInstitution(); | |||
| institution.setKey(IdentificationUtils.generateKey()); | |||
| this.user = Generator.getUser(USERNAME, PASSWORD, "John", "Johnie", "Johnie@gmail.com", institution); | |||
| this.user.setRoleGroup(RoleGroup.OPERATOR_ADMIN.getType()); | |||
blcham
force-pushed
the
202-fine-grained
branch
from
fc33cc1
to
158ac5e
Compare
blcham
reviewed
Sep 18, 2024
src/main/resources/model.ttl
Outdated
Comment on lines
82
to
96
| ### http://onto.fel.cvut.cz/ontologies/record-manager/has-role-group | ||
| rm:has-role-group rdf:type owl:ObjectProperty ; | ||
| rdfs:subPropertyOf rm:relates-to; | ||
| rdfs:label "has role group"@en. | ||
|
|
||
| ### http://onto.fel.cvut.cz/ontologies/record-manager/has-role | ||
| rm:has-role rdf:type owl:ObjectProperty ; | ||
| rdfs:subPropertyOf rm:relates-to; | ||
| rdfs:label "has role"@en. | ||
|
|
palagdan
force-pushed
the
202-fine-grained
branch
from
158ac5e
to
cd76add
Compare
blcham
force-pushed
the
202-fine-grained
branch
from
cd76add
to
3797055
Compare
|
old branch closed in favor of #71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves partially kbss-cvut/record-manager-ui#202
Resolves partially kbss-cvut/record-manager-ui#158