Skip to content

Commit

Permalink
[#219] Handlers call getEffectiveValues(). Create tests for handlers
Browse files Browse the repository at this point in the history
  • Loading branch information
palagdan committed Aug 8, 2024
1 parent ad5ceaf commit c735279
Show file tree
Hide file tree
Showing 15 changed files with 458 additions and 46 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@

import cz.cvut.spipes.engine.ExecutionContext;
import org.apache.jena.rdf.model.Property;
import org.apache.jena.rdf.model.RDFNode;
import org.apache.jena.rdf.model.Resource;
import org.apache.jena.rdf.model.Statement;


public class BooleanHandler extends Handler<Boolean>{
public BooleanHandler(Resource resource, ExecutionContext executionContext, Setter<? super Boolean> setter) {
Expand All @@ -12,9 +13,9 @@ public BooleanHandler(Resource resource, ExecutionContext executionContext, Sett

@Override
public void setValueByProperty(Property property) {
Statement s = resource.getProperty(property);
if (s != null && s.getObject().isLiteral()) {
setter.addValue(s.getBoolean());
RDFNode node = getEffectiveValue(property);
if (node != null && node.isLiteral()) {
setter.addValue(node.asLiteral().getBoolean());
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public Handler(Resource resource, ExecutionContext executionContext, Setter<? su

abstract public void setValueByProperty(Property property);

protected RDFNode getRDFNodeByProperty(Property property){
protected RDFNode getEffectiveValue(Property property){
RDFNode valueNode = Optional.of(resource)
.map(r -> r.getProperty(property))
.map(Statement::getObject)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import cz.cvut.spipes.engine.ExecutionContext;
import org.apache.jena.rdf.model.Property;
import org.apache.jena.rdf.model.RDFNode;
import org.apache.jena.rdf.model.Resource;
import org.apache.jena.rdf.model.Statement;

Expand All @@ -13,9 +14,9 @@ public IntegerHandler(Resource resource, ExecutionContext executionContext, Sett

@Override
public void setValueByProperty(Property property) {
Statement s = resource.getProperty(property);
if (s != null && s.getObject().isLiteral()) {
setter.addValue(s.getInt());
RDFNode node = getEffectiveValue(property);
if (node != null && node.isLiteral()) {
setter.addValue(node.asLiteral().getInt());
}
}
}
Original file line number Diff line number Diff line change
@@ -1,17 +1,12 @@
package cz.cvut.spipes.modules.handlers;

import cz.cvut.spipes.engine.ExecutionContext;
import org.apache.jena.query.QuerySolution;
import org.apache.jena.rdf.model.Property;
import org.apache.jena.rdf.model.RDFNode;
import org.apache.jena.rdf.model.Resource;
import org.apache.jena.rdf.model.Statement;
import org.topbraid.spin.model.SPINFactory;
import org.topbraid.spin.util.SPINExpressions;

import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.Optional;


public class PathHandler extends Handler<Path> {
public PathHandler(Resource resource, ExecutionContext executionContext, Setter<? super Path> setter) {
Expand All @@ -20,9 +15,9 @@ public PathHandler(Resource resource, ExecutionContext executionContext, Setter<

@Override
public void setValueByProperty(Property property) {
RDFNode pathNode = getRDFNodeByProperty(property);
RDFNode pathNode = getEffectiveValue(property);
if(pathNode != null) {
Path path = Paths.get(pathNode.asLiteral().toString());
Path path = Paths.get(pathNode.toString());
setter.addValue(path);
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,16 +1,9 @@
package cz.cvut.spipes.modules.handlers;


import cz.cvut.spipes.engine.ExecutionContext;
import org.apache.jena.query.QuerySolution;
import org.apache.jena.rdf.model.Property;
import org.apache.jena.rdf.model.RDFNode;
import org.apache.jena.rdf.model.Resource;
import org.apache.jena.rdf.model.Statement;
import org.topbraid.spin.model.SPINFactory;
import org.topbraid.spin.util.SPINExpressions;

import java.util.Optional;

public class RDFNodeHandler extends Handler<RDFNode> {
public RDFNodeHandler(Resource resource, ExecutionContext executionContext, Setter<? super RDFNode> setter) {
Expand All @@ -19,7 +12,7 @@ public RDFNodeHandler(Resource resource, ExecutionContext executionContext, Sett

@Override
public void setValueByProperty(Property property) {
RDFNode node = getRDFNodeByProperty(property);
RDFNode node = getEffectiveValue(property);
if(node != null) {
setter.addValue(node);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import cz.cvut.spipes.engine.ExecutionContext;
import org.apache.jena.rdf.model.Property;
import org.apache.jena.rdf.model.RDFNode;
import org.apache.jena.rdf.model.Resource;
import org.apache.jena.rdf.model.Statement;
import org.topbraid.spin.model.Select;
Expand All @@ -14,9 +15,9 @@ public SelectHandler(Resource resource, ExecutionContext executionContext, Sette

@Override
public void setValueByProperty(Property property) {
Statement s = resource.getProperty(property);
if (s != null && s.getObject().isLiteral()) {
setter.addValue(s.getObject().asResource().as(Select.class));
RDFNode node = getEffectiveValue(property);
if (node != null) {
setter.addValue(node.asResource().as(Select.class));
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

import cz.cvut.spipes.engine.ExecutionContext;
import org.apache.jena.rdf.model.Property;
import org.apache.jena.rdf.model.RDFNode;
import org.apache.jena.rdf.model.Resource;
import org.apache.jena.rdf.model.Statement;

public class StringHandler extends Handler<String> {

Expand All @@ -14,11 +14,9 @@ public StringHandler(Resource resource, ExecutionContext executionContext, Sette

@Override
public void setValueByProperty(Property property) {

Statement s = resource.getProperty(property);

if (s != null && s.getObject().isLiteral()) {
setter.addValue(s.getString());
RDFNode node = getEffectiveValue(property);
if (node != null) {
setter.addValue(node.toString());
}
}
}
Original file line number Diff line number Diff line change
@@ -1,18 +1,10 @@
package cz.cvut.spipes.modules.handlers;

import cz.cvut.spipes.constants.SML;
import cz.cvut.spipes.engine.ExecutionContext;
import org.apache.jena.query.QuerySolution;
import org.apache.jena.rdf.model.Property;
import org.apache.jena.rdf.model.RDFNode;
import org.apache.jena.rdf.model.Resource;
import org.apache.jena.rdf.model.Statement;
import org.topbraid.spin.model.SPINFactory;
import org.topbraid.spin.util.SPINExpressions;

import cz.cvut.spipes.engine.ExecutionContext;
import org.apache.jena.rdf.model.*;
import java.net.MalformedURLException;
import java.net.URL;
import java.util.Optional;

public class URLHandler extends Handler<URL>{
public URLHandler(Resource resource, ExecutionContext executionContext, Setter<? super URL> setter) {
Expand All @@ -22,10 +14,11 @@ public URLHandler(Resource resource, ExecutionContext executionContext, Setter<?
@Override
public void setValueByProperty(Property property) {
URL url;
RDFNode urlNode = getRDFNodeByProperty(property);
if (urlNode != null) {
RDFNode urlNode = getEffectiveValue(property);

if (urlNode != null && urlNode.isLiteral()) {
try {
url = new URL(urlNode.asLiteral().toString());
url = new URL(urlNode.toString());
setter.addValue(url);
} catch (MalformedURLException e) {
throw new RuntimeException(e);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
package cz.cvut.spipes.modules.handlers;

import cz.cvut.spipes.engine.ExecutionContext;
import org.apache.jena.rdf.model.*;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import static org.mockito.Mockito.*;

public class BooleanHandlerTest {

private BooleanHandler booleanHandler;
private Resource mockResource;
private ExecutionContext mockExecutionContext;
private Setter<Boolean> mockSetter;
private Property mockProperty;
private Model model;

@BeforeEach
public void setUp() {
mockResource = mock(Resource.class);
mockExecutionContext = mock(ExecutionContext.class);
mockSetter = mock(Setter.class);
mockProperty = mock(Property.class);
model = ModelFactory.createDefaultModel();

booleanHandler = new BooleanHandler(mockResource, mockExecutionContext, mockSetter);
}

@Test
public void testSetValueByPropertyWithBooleanLiteral() {
RDFNode booleanLiteralNode = model.createLiteral(String.valueOf(true));
Statement mockStatement = mock(Statement.class);

when(mockResource.getProperty(mockProperty)).thenReturn(mockStatement);
when(mockStatement.getObject()).thenReturn(booleanLiteralNode);

booleanHandler.setValueByProperty(mockProperty);

verify(mockSetter).addValue(true);
}

@Test
public void testSetValueByPropertyWithNonLiteralNode() {
RDFNode nonLiteralNode = model.createResource();
Statement mockStatement = mock(Statement.class);

when(mockResource.getProperty(mockProperty)).thenReturn(mockStatement);
when(mockStatement.getObject()).thenReturn(nonLiteralNode);

booleanHandler.setValueByProperty(mockProperty);

verify(mockSetter, never()).addValue(anyBoolean());
}

@Test
public void testSetValueByPropertyWithNullNode() {
when(mockResource.getProperty(mockProperty)).thenReturn(null);

booleanHandler.setValueByProperty(mockProperty);

verify(mockSetter, never()).addValue(anyBoolean());
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
package cz.cvut.spipes.modules.handlers;

import cz.cvut.spipes.engine.ExecutionContext;
import org.apache.jena.rdf.model.Property;
import org.apache.jena.rdf.model.RDFNode;
import org.apache.jena.rdf.model.Resource;
import org.apache.jena.rdf.model.Statement;
import org.apache.jena.rdf.model.Model;
import org.apache.jena.rdf.model.ModelFactory;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.*;
import static org.mockito.Mockito.*;

public class HandlerTest {

private Handler<Object> handler;
private Resource mockResource;
private ExecutionContext mockExecutionContext;
private Setter<Object> mockSetter;
private Property mockProperty;
private Model model;

@BeforeEach
public void setUp() {
mockResource = mock(Resource.class);
mockExecutionContext = mock(ExecutionContext.class);
mockSetter = mock(Setter.class);
mockProperty = mock(Property.class);
model = ModelFactory.createDefaultModel();

handler = new Handler<Object>(mockResource, mockExecutionContext, mockSetter) {
@Override
public void setValueByProperty(Property property) {

}
};
}

@Test
public void testGetEffectiveValueWhenNotExpression() {
RDFNode expectedNode = model.createLiteral("value");
Statement mockStatement = mock(Statement.class);

when(mockResource.getProperty(mockProperty)).thenReturn(mockStatement);
when(mockStatement.getObject()).thenReturn(expectedNode);

RDFNode result = handler.getEffectiveValue(mockProperty);

assertEquals(expectedNode, result);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
package cz.cvut.spipes.modules.handlers;

import cz.cvut.spipes.engine.ExecutionContext;
import org.apache.jena.rdf.model.*;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import static org.mockito.Mockito.*;

public class IntegerHandlerTest {

private IntegerHandler integerHandler;
private Resource mockResource;
private ExecutionContext mockExecutionContext;
private Setter<Integer> mockSetter;
private Property mockProperty;
private Model model;

@BeforeEach
public void setUp() {
mockResource = mock(Resource.class);
mockExecutionContext = mock(ExecutionContext.class);
mockSetter = mock(Setter.class);
mockProperty = mock(Property.class);
model = ModelFactory.createDefaultModel();

integerHandler = new IntegerHandler(mockResource, mockExecutionContext, mockSetter);
}

@Test
public void testSetValueByPropertyWithIntegerLiteral() {
RDFNode integerLiteralNode = model.createLiteral(String.valueOf(42));
Statement mockStatement = mock(Statement.class);

when(mockResource.getProperty(mockProperty)).thenReturn(mockStatement);
when(mockStatement.getObject()).thenReturn(integerLiteralNode);

integerHandler.setValueByProperty(mockProperty);

verify(mockSetter).addValue(42);
}

@Test
public void testSetValueByPropertyWithNonLiteralNode() {
RDFNode nonLiteralNode = model.createResource();
Statement mockStatement = mock(Statement.class);

when(mockResource.getProperty(mockProperty)).thenReturn(mockStatement);
when(mockStatement.getObject()).thenReturn(nonLiteralNode);

integerHandler.setValueByProperty(mockProperty);

verify(mockSetter, never()).addValue(anyInt());
}

@Test
public void testSetValueByPropertyWithNullNode() {

when(mockResource.getProperty(mockProperty)).thenReturn(null);

integerHandler.setValueByProperty(mockProperty);

verify(mockSetter, never()).addValue(anyInt());
}
}
Loading

0 comments on commit c735279

Please sign in to comment.