Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support simple implementation of excel files in tabular module #204

Closed
2 of 3 tasks
blcham opened this issue Sep 2, 2023 · 5 comments · Fixed by #203
Closed
2 of 3 tasks

Support simple implementation of excel files in tabular module #204

blcham opened this issue Sep 2, 2023 · 5 comments · Fixed by #203
Assignees

Comments

@blcham
Copy link
Contributor

blcham commented Sep 2, 2023

This ticket is simplification of ticket #201 where we want to support extraction of one sheet only and does not support merged cells (#215).

After this ticket is done we will extend the implementation to achieve #201.

A/C:

  • there is required parameter to process only one sheet
  • functionality is tested with JUNIT tests using ´assertIsomorphic(actualModel, expectedModel);´
  • if implemented using property holding mime-type value, it should be checked that combination of delimiter value and mime-type values are together consistent
@blcham blcham changed the title Support excel files in tabular module with restriction to one sheet Support simple implementation of excel files in tabular module Sep 2, 2023
@rodionnv
Copy link
Contributor

rodionnv commented Sep 4, 2023

@blcham
"...if implemented using property holding mime-type value, it should be checked that combination of delimiter value and mime-type values are together consistent"

I don't quite understand, there will be both parameters "delimiter" and "source-resource-format"? Or there will be only "source-resource-format" and later in the module it should be checked if the actual paraemeter is consistent with format?

@blcham
Copy link
Contributor Author

blcham commented Sep 4, 2023

if you choose tab-separated-values mime type, it should make by default delimiter "tab" and escaping should be set by default acording to specification as well ... if you override delimiter i would throw exception as it is not tab-separated-values anymore ..

@blcham
Copy link
Contributor Author

blcham commented Sep 4, 2023

we should always know what specification we refer to and if we set it up, we should be compliant with it or throw exception. Within the exception there should be link to the specification we used.

@blcham
Copy link
Contributor Author

blcham commented Sep 4, 2023

Also it should be valid to not set mime-type and assume it is plain text with delimiters and quote-ing set explicitely.

@blcham
Copy link
Contributor Author

blcham commented Sep 4, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants