New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify URIs of module parameters #275

Open

blcham opened this issue Sep 13, 2024 · 1 comment

Contributor

blcham commented Sep 13, 2024 •

edited

Loading

There are multiple ways in which parameter URIs are defined:

e.g. Ckan2RdfModule prefixes all properties by p-, i.e. @Parameter(iri = TYPE_URI + "/" + "p-ckan-url", comment = "URL of the CKAN server.")
e.g. TabularModule -- @Parameter(iri = PARAM_URL_PREFIX + "source-resource-uri"

There are multiple use cases for parameters:

some parameters are reusable across all modules (kbss-module:has-input-graph-constraint)
some parameters are reusable (e.g. sml:replace, kbss-module:is-parse-text, kbss-module:has-resource-uri)-
some parameters are not reusable at all

A/C:

A guide to README is added what is the best practice to create new reusable/specific params and how/when to migrate params from specific to reusable
module parameters are refactored according to the guide while there is also mechanism how to log deprecated parameters of modules

The text was updated successfully, but these errors were encountered:

blcham mentioned this issue

[#258] Refactor @Parameter to include iri instead of (urlPrefix, name) #273

Merged

Contributor Author

blcham commented Sep 13, 2024

I suggest to start refactoring most used modules first such as Tabular module and create TABULAR.java for the prefixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment