Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Initial implementation of RetrievePrefixModule #176

Merged
merged 9 commits into from
Jul 18, 2023
Merged

Conversation

rodionnv
Copy link
Contributor

No description provided.

@blcham
Copy link
Contributor

blcham commented Jul 12, 2023

@rodionnv

Currently, implementation has the issue of having an absolute path in tests, we need to find a solution of removing it. The relative path might be the issue as well as it could be executed from different directories. Try to look for some standard solution (?! maybe extract resources into tmp directory and load it from there?)

@blcham
Copy link
Contributor

blcham commented Jul 16, 2023

@rodionnv if you are done here ... add me as reviewer

@rodionnv rodionnv requested a review from blcham July 16, 2023 14:54
@blcham blcham self-requested a review July 16, 2023 20:56
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job. See my last commits and make sure you understand what it does. You can merge this pull request.

@blcham blcham merged commit d039b9a into main Jul 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants