-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] Initial implementation of RetrievePrefixModule #176
Conversation
Currently, implementation has the issue of having an absolute path in tests, we need to find a solution of removing it. The relative path might be the issue as well as it could be executed from different directories. Try to look for some standard solution (?! maybe extract resources into tmp directory and load it from there?)
|
Still throw error while using mockito framework.
@rodionnv if you are done here ... add me as reviewer |
s-pipes-core/src/main/java/cz/cvut/spipes/modules/RetrievePrefixesModule.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job. See my last commits and make sure you understand what it does. You can merge this pull request.
No description provided.