Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#181] Add new test for Rdf4jDeployModule #187

Merged
merged 7 commits into from
Aug 16, 2023
Merged

[#181] Add new test for Rdf4jDeployModule #187

merged 7 commits into from
Aug 16, 2023

Conversation

rodionnv
Copy link
Contributor

@rodionnv rodionnv commented Aug 1, 2023

No description provided.

@rodionnv rodionnv requested a review from blcham August 2, 2023 14:02
blcham
blcham requested changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test does not really test anything ... It should be done in a same way as Rdf4jUpdateModule, moreover you are committing stuff that you do not use ... see my next commit.

s-pipes-modules/module-rdf4j/pom.xml Outdated Show resolved Hide resolved
s-pipes-modules/module-rdf4j/pom.xml Outdated Show resolved Hide resolved
s-pipes-modules/module-rdf4j/src/test/java/cz/cvut/spipes/modules/Rdf4jDeployModuleTest.java Show resolved Hide resolved
blcham
blcham requested changes Aug 6, 2023
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments

s-pipes-modules/module-rdf4j/src/main/java/cz/cvut/spipes/modules/Rdf4jDeployModule.java Show resolved Hide resolved
s-pipes-modules/module-rdf4j/src/main/java/cz/cvut/spipes/modules/Rdf4jDeployModule.java Outdated Show resolved Hide resolved
s-pipes-modules/module-rdf4j/src/main/java/cz/cvut/spipes/modules/Rdf4jDeployModule.java Outdated Show resolved Hide resolved
s-pipes-modules/module-rdf4j/src/test/java/cz/cvut/spipes/modules/Rdf4jDeployModuleTest.java Outdated Show resolved Hide resolved
s-pipes-modules/module-rdf4j/src/test/java/cz/cvut/spipes/modules/Rdf4jDeployModuleTest.java Outdated Show resolved Hide resolved
s-pipes-modules/module-rdf4j/src/test/java/cz/cvut/spipes/modules/Rdf4jDeployModuleTest.java Show resolved Hide resolved
@rodionnv rodionnv requested a review from blcham August 14, 2023 09:05
@blcham
Copy link
Contributor

blcham commented Aug 14, 2023

@rodionnv still see 4 comments not answered.

@blcham blcham merged commit b18620a into main Aug 16, 2023
2 checks passed
@blcham blcham changed the title [Upd] Add new test for Rdf4jDeployModule [#181] Add new test for Rdf4jDeployModule Aug 18, 2023
@blcham
Copy link
Contributor

blcham commented Aug 18, 2023

resolves #181

@blcham blcham deleted the add-test-to-Rdf4jDeployModule branch August 24, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blcham blcham Awaiting requested review from blcham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodionnv @blcham