Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#205] Fix declaring parameters from unrelated modules in RDF module descriptions. #209

Closed

Conversation

kostobog
Copy link
Contributor

@kostobog kostobog commented Sep 7, 2023

Fixes #205, #206

#205

  • delete incorrect sharing of parameter declaration among modules in writeConstraintsToModel
  • add subClassOf triple to modules extending other modules, including abstract ones, to share parameter declaratoin with their super classes.
  • Note that tools using the generated descriptions of modules that extend other modules will have to query the super classes for their parameter declaration.

#206

  • Add SPipesModule and Parameter annotations to all modules in s-pipes-module subprojects.

…descriptions

- delete incorrect sharing of parameter declaration among modules in writeConstraintsToModel
- add subClassOf triple to modules extending other modules, including abstract ones, to share parameter declaratoin with their super classes.
- Note that tools using the generated descriptions of modules that extend other modules will have to query the super classes for their parameter declaration.
@kostobog kostobog requested a review from blcham September 7, 2023 10:43
@kostobog kostobog closed this Sep 8, 2023
@kostobog kostobog deleted the issues/issue205-module-creator-plugin-outputs-wrong-rdf branch September 8, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s-pipes-module-creator-maven-plugin Generates Wrong Module RDF Description
1 participant