Add merged cells metadata in tabular module #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blcham
reviewed
Oct 4, 2023
s-pipes-modules/module-tabular/src/main/java/cz/cvut/spipes/modules/model/Cell.java
Outdated
Show resolved
Hide resolved
blcham
reviewed
Oct 4, 2023
s-pipes-modules/module-tabular/src/main/java/cz/cvut/spipes/modules/model/Cell.java
Outdated
Show resolved
Hide resolved
blcham
reviewed
Oct 4, 2023
s-pipes-modules/module-tabular/src/test/resources/merged-xls-model-output.ttl
Outdated
Show resolved
Hide resolved
blcham
reviewed
Oct 4, 2023
s-pipes-modules/module-tabular/src/test/resources/merged-xls-model-output.ttl
Outdated
Show resolved
Hide resolved
blcham
reviewed
Oct 4, 2023
s-pipes-modules/module-tabular/src/test/resources/merged-xls-model-output.ttl
Outdated
Show resolved
Hide resolved
blcham
requested changes
Oct 4, 2023
…th a csvw:Cell and a csvw:Schema
[Upd] Improve logs when reading input file with tabular data fails
…th a csvw:Cell and a csvw:Schema
… tables. Requires fix for wrong row and column indexes.
|
@blcham Can you please check, I am not sure if I have correctly rebased changes from main into this branch because there are duplicated commits now. |
blcham
reviewed
Oct 25, 2023
s-pipes-modules/module-tabular/src/main/java/cz/cvut/spipes/modules/model/Cell.java
Show resolved
Hide resolved
|
This pull request was closed in favor of #226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.