Improve logging for query parse error in ApplyConstructModule #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blcham
changed the title
Closed
|
I've changed all calls to ARQFactory.get().createCommandString() so they'll pass through our createQuery function everywhere. |
|
LGTM, just please try to fulfill A/C (acceptance criteria) defined in #231 (comment) (i.e. I would like to see how it looks in the log) |
blcham
force-pushed
the
231-improve-query-parse-error-logging
branch
2 times, most recently
from
cd2a0bb
to
cf87630
Compare
blcham
force-pushed
the
231-improve-query-parse-error-logging
branch
from
cf87630
to
744a106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #231