Nuke 13 – Swift 6 #802
Open
Nuke 13 – Swift 6 #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcbriones
approved these changes
Oct 23, 2024
larryonoff
reviewed
Jan 22, 2025
| @@ -4,11 +4,11 @@ | |||
|
|
|||
| import Foundation | |||
|
|
|||
| final class Atomic<T>: @unchecked Sendable { | |||
There was a problem hiding this comment.
I assume that it would be good to take Mutex backport implementation from swift-sharing framework, which is ported from Swift.Synchronization
There was a problem hiding this comment.
Hmm, interesting. Thanks for the link. I'll look into it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Changes
ImagePipelineActor
Nuke has been designed around the global actor pattern for quite a while now, so it was an easy change to introduce a global
ImagePipelineActoras a replacement.ImagePipeline,ImagePrefetcher,ImageTask, and allAsyncTaskimplementations are now syncrhonized on the new actor instead of a a serial GCD queue.