Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run a processor with a custom tag #333

Open
ondrejhlavacek opened this issue Jul 25, 2018 · 4 comments
Open

run a processor with a custom tag #333

ondrejhlavacek opened this issue Jul 25, 2018 · 4 comments

Comments

@ondrejhlavacek
Copy link
Member

potřebujeme zavést integrační testy pro procesory, teď se dvakrát stalo, že se deploynul nefunkční procesor (datadir testy to nezachytily)

Tohle by se mohlo uložit do configu, kterej bude procesor testovat

{
    "definition": {
        "component": "keboola.processor-filter-files",
        "tag": "test"
    },
    "parameters": {
        "mask": "myfile.csv"
    }
}

a Docker Runner by mohl pustit procesor s daným tagem.

@Halama
Copy link
Member

Halama commented Jul 25, 2018

tohle se předtím dost řešilo, ale nakonec asi potřeba budou keboola/processor-create-manifest#16

@Halama
Copy link
Member

Halama commented Jul 25, 2018

@ondrejhlavacek
Copy link
Member Author

jo budou, včera se mi to stalo dvakrát při dost triviálních změnách. neodchytly to datadir testy ani několikanásobný review.

@Halama
Copy link
Member

Halama commented Jul 31, 2018

Hodilo by se to nejenom na ty testy. Teď bych např. dočasně pro jednu konfiguraci potřeboval nastavit starší verzi processoru.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants