feat: expose idleReplicaCount param to httpScaledObject #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucakuendig
force-pushed
the
add_idleReplicaCount
branch
from
fd57b33
to
071d083
Compare
tomkerkhove
reviewed
Feb 2, 2023
abatilo
approved these changes
Feb 5, 2023
|
hello @lucakuendig |
|
Hello, any update on this? |
Signed-off-by: Luca Kuendig <luca.kuendig@bedag.ch>
lucakuendig
force-pushed
the
add_idleReplicaCount
branch
from
8c8820e
to
55f4b8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luca Kuendig luca.kuendig@bedag.ch
I added spec.replicas.idle which allows to pass a value for spec.idleReplicaCount to the generated ScaledObject. We need this to work for our current use-case.
Pls tell me if I need to update any docs. On first glance I could not find anything that would need an update.
Checklist
README.mddocs/directoryFixes #