Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync sample CRs from main repo during releases #234

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

joelsmith
Copy link
Contributor

We're currently missing an example for the new cloudeventsource CRD. Hopefully this change will keep that from happening in the future. As long as kedacore/keda#5921 merges before the 2.15 release, this will clean things up for that release.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

@joelsmith joelsmith requested a review from zroubalik as a code owner June 28, 2024 16:39
Signed-off-by: Joel Smith <joelsmith@redhat.com>
@jkyros
Copy link
Contributor

jkyros commented Jun 28, 2024

So we:

  • overwrite our operator kustomization yaml with the operand's
  • then for each thing in it, we grab the matching sample into our repo
  • then we add our kedacontroller type back to our kustomization yaml (because we overwrote ours, and the operand doesn't have kedacontroller, but we do)

Awesome. Love it.

/lgtm

@joelsmith joelsmith merged commit 8771bfa into kedacore:main Jun 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants