Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install kedro-datasets[<optional>] doesn't work with pip 24.0 #553

Closed
noklam opened this issue Feb 12, 2024 · 1 comment
Closed

pip install kedro-datasets[<optional>] doesn't work with pip 24.0 #553

noklam opened this issue Feb 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@noklam
Copy link
Contributor

noklam commented Feb 12, 2024

Description

pip has been an ongoing issue with CI, but now it's also affecting users. For an user who start with an environment with pip==24.0, after running kedro-datasets[pandas.ParquetDataest], it does not fail but rather silently skip depdencies such as pyarrow.

pip related hot fixes recently:

Context

Steps to Reproduce

Expected Result

Actual Result

-- If you received an error, place it here.
-- Separate them if you have more than one.

Your Environment

  • Kedro version used (pip show kedro or kedro -V):
  • Python version used (python -V):
  • Operating system and version:
@noklam noklam transferred this issue from kedro-org/kedro Feb 12, 2024
@noklam noklam added the bug Something isn't working label Feb 12, 2024
@astrojuanlu
Copy link
Member

Confirmed. With pip 23.3 onwards:

WARNING: kedro-datasets 2.0.0 does not provide the extra 'pandas-parquetdataset'

With pip < 23.3 it proceeds normally.

From the changelog: https://pip.pypa.io/en/stable/news/#v23-3

Normalize extras according to PEP 685 from package metadata in the resolver for comparison. This ensures extras are correctly compared and merged as long as the package providing the extra(s) is built with values normalized according to the standard. Note, however, that this does not solve cases where the package itself contains unnormalized extra values in the metadata. (#11649)

Closing this as duplicate of #313 and raising the priority of that one.

@astrojuanlu astrojuanlu closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants