make plugin=kedro-datasets install-test-requirements fails
#597
Comments
|
Thanks for the report @grofte , we'll look into this. |
|
@grofte What pip version is this? |
Time to update the contribution readme too 👍🏽 |
|
You're right tho, pip version does matter. I would suggest that you change |
|
Good shout about the readme, on the other hand we need more information. https://github.com/kedro-org/kedro/actions/runs/8158985607/job/22302183993 Most likely pip version problem. |
|
I don't even understand how Dask depending on Dask and kedro-datasets depending on Dask gives a conflict. Anyway, I installed Running the rest of the CI worked and EDIT: omg you guys, uv was sooooo much faster |
Yep 😄 we're using it in our CI already. About the google dependency, we requested that they yank it, since it's invalid, but they didn't seem to fully understand and they closed the issue already googleapis/python-bigquery#1818
Ughhhhh. I'm sorry, hope it was not too painful. |
|
I did manage to do a draft PR and I probably fucked everything up =D |
|
I confirm this is still the case as of today. ...and yet, In fact, the So a dependency solution exists - it's just that Admittedly, the test dependencies for And yet, our Makefile uses Are we ready to change our Makefile to use |
|
Btw another contributor was blocked by this #807 (comment) |
|
Data point...trying to work on a PR for #808 and ran in to this issue...I'll try Using python 3.10, pip 24.2 (latest) |
|
Well, every single kedro-datasets contributor is being blocked by this, so I'm liberally assigning High priority. |
astrojuanlu
changed the title
make plugin=kedro-datasets install-test-requirements fails
4 tasks
|
As @ankatiyar pointed out on a meeting today, we're now using kedro-plugins/.github/workflows/unit-tests.yml Lines 47 to 51 in b766f45 We can do several things:
Thoughts? |
|
I have actually fixed |
|
I see we merged this a few days after we last spotted the problem #597 (comment) let's close the issue |
|
Sounds good, I have added a note in the installation guide (Github Wiki). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Running
make plugin=kedro-datasets install-test-requirementsdoes not work. Dependency conflicts.Edit by @astrojuanlu: Summary and possible next steps at #597 (comment)
Context
I wanted to contribute a PR for some Polars support but I can't install the dependencies.
Steps to Reproduce
conda create -n PR-kedro python=3.9(contribution readme says 3.6+ but PyPi says 3.9+)conda activate PR-kedromake plugin=kedro-datasets install-test-requirementsExpected Result
Pip should install the required libraries.
Actual Result
Pip did not.
Let me know if you want the full message from Pip but I think this covers all the relevant information.
Your Environment
Include as many relevant details about the environment in which you experienced the bug:
pip show kedroorkedro -V): currentpip show kedro-airflow): currentpython -V): 3.9.18The text was updated successfully, but these errors were encountered: