ci: Clean up of Makefile and Gitpod setup #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
noklam
changed the title
merelcht
reviewed
Jan 9, 2024
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
astrojuanlu
reviewed
Jan 10, 2024
16 tasks
|
@noklam Do you still want to get this in? |
|
@merelcht Sure, let me try to update this is still very useful to review datasets PR. I will update the make command with uv as well. |
noklam
changed the title
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
astrojuanlu
reviewed
Aug 27, 2024
| install-test-requirements: | ||
| cd $(plugin) && pip install ".[test]" | ||
| cd $(plugin) && uv pip install ".[test]" |
astrojuanlu
reviewed
Aug 27, 2024
astrojuanlu
reviewed
Aug 27, 2024
astrojuanlu
reviewed
Aug 27, 2024
| init: | | ||
| sudo apt-get update && sudo apt-get install -y --no-install-recommends libgl1 | ||
| sudo apt-get install make | ||
| sudo apt-get install -y --no-install-recommends libatk-bridge2.0-0 libcups2 ca-certificates fonts-liberation libasound2 libatk-bridge2.0-0 libatk1.0-0 libc6 libcairo2 libcups2 libdbus-1-3 libexpat1 libfontconfig1 libgbm1 libgcc1 libglib2.0-0 libgtk-3-0 libnspr4 libnss3 libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 libxtst6 lsb-release wget xdg-utils |
There was a problem hiding this comment.
Are all these system deps needed to install stuff on Gitpod? Bummer...
There was a problem hiding this comment.
^frankly I didn't test it 1 by 1, this list of dependencies has lived in kedro for a while since the introduction of VideoDataset. opencv seems to relies on some shared libraries.
There was a problem hiding this comment.
Oh so it's because of OpenCV, got it 👍🏼
astrojuanlu
approved these changes
Aug 27, 2024
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
harm-matthias-harms
pushed a commit
to harm-matthias-harms/kedro-plugins
that referenced
this pull request
Oct 1, 2024
* switch to Dockerfile, same configuration as the kedro branch. Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * simplify setup Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * update makefile Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * simplified install in background while not slowing down startup Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * fix command Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * fix setup Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * combined makefile Signed-off-by: Nok <nok.lam.chan@quantumblack.com> --------- Signed-off-by: Nok <nok.lam.chan@quantumblack.com> Signed-off-by: Harm Matthias Harms <matthias.harms@quis.de>
MinuraPunchihewa
pushed a commit
to MinuraPunchihewa/kedro-plugins
that referenced
this pull request
Oct 1, 2024
* switch to Dockerfile, same configuration as the kedro branch. Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * simplify setup Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * update makefile Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * simplified install in background while not slowing down startup Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * fix command Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * fix setup Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * combined makefile Signed-off-by: Nok <nok.lam.chan@quantumblack.com> --------- Signed-off-by: Nok <nok.lam.chan@quantumblack.com> Signed-off-by: Minura Punchihewa <minurapunchihewa17@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the setup, particular
kedro-datasetsrequirements are harder to install for contributors.Development notes
I decided not to use Docker because of the way Gitpod work, building docker would take up most of the time and the UI does not show up until this is finished.
Checklist
RELEASE.mdfile