fix(telemetry): Masking test #764
Conversation
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
| @@ -20,6 +20,7 @@ | |||
| PACKAGE_NAME = "cli_tools_dummy_package" | |||
| DEFAULT_KEDRO_COMMANDS = [ | |||
| "catalog", | |||
| "info", | |||
There was a problem hiding this comment.
Any idea why "info" was not in DEFAULT_KEDRO_COMMANDS before?
There was a problem hiding this comment.
I suspect it’s connected to these changes Lazy load click subcommands PR
There was a problem hiding this comment.
I think info is part of the global commands.
There was a problem hiding this comment.
Hmm actually I'm not 100% sure, but it looks like the info command is part of a different separate CLI group compared to the others. @ankatiyar probably knows best 😄
There was a problem hiding this comment.
info is a separate group because the group has the help text that shows up on top when you do kedro --help. I didn't change the setup to lazy for that just in case something broke. The cli group is called cli and the module itself is also called cli., I suspect the test setup was a bit weird with some mocking and importing so info wasn't getting discovered in tests but I'm also not a 100%
For example, see the tests/framework/cli/test_cli_hooks.py in kedro-org/kedro#3883 😕
Fix telemetry masking test Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Description
Fix #763
Development notes
Checklist
RELEASE.mdfile