Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(docker): Update error code on e2e tests #813

Merged
merged 6 commits into from
Aug 27, 2024
Merged

ci(docker): Update error code on e2e tests #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1e9cfe0
Update error message docker
ankatiyar Aug 22, 2024
331237e
typo
ankatiyar Aug 22, 2024
3721bd4
Merge branch 'main' into ci-stuff-docker
ankatiyar Aug 27, 2024
f7ed076
Update step
ankatiyar Aug 27, 2024
b50de1c
Change exit code
ankatiyar Aug 27, 2024
b0c8f7a
Error message
ankatiyar Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kedro-docker/features/docker.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ Feature: Docker commands in new projects

Scenario: Execute docker run target without building image
When I execute the kedro command "docker run"
Then I should get an error exit code
Then I should get a successful exit code
And Standard output should contain a message including "Error: Unable to find image `project-dummy` locally."

Scenario: Execute docker dive target
Expand All @@ -118,5 +118,5 @@ Feature: Docker commands in new projects

Scenario: Execute docker dive without building image
When I execute the kedro command "docker dive"
Then I should get an error exit code
Then I should get a successful exit code
And Standard output should contain a message including "Error: Unable to find image `project-dummy` locally."
2 changes: 1 addition & 1 deletion kedro-docker/features/steps/cli_steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ def check_status_code(context):
print(context.result.stderr)
assert (
False
), f"Expected exit code {OK_EXIT_CODE} but got {context.result.returncode}"
), f"Expected exit code /= {OK_EXIT_CODE} but got {context.result.returncode}"


@then("I should get an error exit code")
Expand Down