Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove support for python 3.8 for kedro-airflow #877

Merged

Conversation

felixscherz
Copy link
Contributor

@felixscherz felixscherz commented Oct 9, 2024

Description

This is in regards to #872, dropping python 3.8 support for kedro-airflow. Intends to resolve #874.

Development notes

  • removed python 3.8 from github actions matrix
  • updated pyproject.toml
  • updated python syntax to conform with python 3.9 and above

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Felix Scherz <felixwscherz@gmail.com>
@felixscherz felixscherz changed the title chore: removed support for python 3.8 for kedro-airflow chore: remove support for python 3.8 for kedro-airflow Oct 9, 2024
Signed-off-by: Felix Scherz <felixwscherz@gmail.com>
@felixscherz
Copy link
Contributor Author

I had to remove Python 3.8 from the test matrix for both kedro-docker and kedro-telemetry in order to get the CI to run, all further changes are part of their respective PRs dropping support for Python 3.8

Signed-off-by: Felix Scherz <felixwscherz@gmail.com>
Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

Copy link
Contributor

@ElenaKhaustova ElenaKhaustova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @felixscherz!

@ankatiyar ankatiyar enabled auto-merge (squash) October 10, 2024 12:20
@ankatiyar ankatiyar merged commit 6adb823 into kedro-org:main Oct 10, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kedro-airflow: Nightly build failure
3 participants