ci: Add GH action to check for TSC votes on core dataset changes #896
+51
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
merelcht
changed the title
|
This will need to be added to the |
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
ankatiyar
approved these changes
Oct 18, 2024
noklam
approved these changes
Oct 18, 2024
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
…dro-org/kedro-plugins into add-action-to-check-tsc-votes
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
tdhooghe
pushed a commit
to tdhooghe/kedro-plugins
that referenced
this pull request
Oct 21, 2024
…ro-org#896) * Add GH action to check for TSC votes on core dataset changes * Ignore TSC vote action in gatekeeper * Trigger TSC vote action only on changes in core dataset --------- Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com> Signed-off-by: tdhooghe <thomas_dhooghe@mckinsey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an automated check to get 1/2 TSC approvals on core dataset changes.
Development notes
This solution isn't perfect, because it will also trigger on any changes to existing datasets and we only need an official votes for new datasets being contributed to the core datasets.
I suggest we don't make this a mandatory check, but it will serve as an automatic reminder to check if we need a TSC vote.
Example of this check in action: https://github.com/merelcht/kedro-plugins/pull/3
Checklist
RELEASE.mdfile