Fix windows builds (#1171)

* Try to fix windows builds

Signed-off-by: Tynan DeBold <thdebold@gmail.com>

* Avoid the node/install part of the process

Signed-off-by: Tynan DeBold <thdebold@gmail.com>

* Check node version in npm_build step

Signed-off-by: Tynan DeBold <thdebold@gmail.com>

* Revert to install_node_dependencies to check error

Signed-off-by: Tynan DeBold <thdebold@gmail.com>

* Run npm install without installing node

Signed-off-by: Tynan DeBold <thdebold@gmail.com>

* Run npm install without installing node with correct indent

Signed-off-by: Tynan DeBold <thdebold@gmail.com>

* Use nvm for all installs

Signed-off-by: Tynan DeBold <thdebold@gmail.com>

* Run nvm_use_npm_install for windows builds only

Signed-off-by: Tynan DeBold <thdebold@gmail.com>

* Seems to work, so revert filters and branch-specific triggers

Signed-off-by: Tynan DeBold <thdebold@gmail.com>

* Remove unused command

Signed-off-by: Tynan DeBold <thdebold@gmail.com>

Signed-off-by: Tynan DeBold <thdebold@gmail.com>

.circleci/continue_config.yml

@@ -50,24 +50,28 @@ commands:
           name: Install Node dependencies
           command: npm install
 
-  win_install_nvm:
+  nvm_use_npm_install:
     steps:
-      - run: choco install wget -y
       - run:
-          command: wget https://nodejs.org/dist/v16.13.2/node-v16.13.2-x86.msi -P C:\Users\circleci\Downloads\
-          shell: cmd.exe
-      - run: MsiExec.exe /i C:\Users\circleci\Downloads\node-v16.13.2-x86.msi /qn
+          name: Use NVM to run Node v16
+          command: |
+            nvm install v16.13.2
+            node -v
+            nvm alias default v16.13.2
+            nvm use v16.13.2
       - run:
+          name: Install Node dependencies
           command: |
-            Start-Process powershell -verb runAs -Args "-start GeneralProfile"
-            nvm install 16.13.2
-            nvm use 16.13.2
+            node -v
+            npm install
 
   npm_build:
     steps:
       - run:
           name: Build React application
-          command: make build
+          command: |
+            node -v
+            make build
 
   win_setup_python_env:
     # Miniconda3 is pre-installed on the machine:
@@ -114,8 +118,7 @@ commands:
       - checkout
       - win_setup_python_env:
           python_version: <<parameters.python_version>>
-      - win_install_nvm
-      - install_node_dependencies
+      - nvm_use_npm_install
       - npm_build
 
 jobs: