Skip to content

Commit

Permalink
Use _get_config_credentials() in catalog CLI
Browse files Browse the repository at this point in the history
Update RELEASE.md

Signed-off-by: Miguel Rodriguez Gutierrez <miguel7r@hotmail.com>
  • Loading branch information
MigQ2 committed Sep 15, 2024
1 parent 7e02653 commit 810a538
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
* Enhanced `OmegaConfigLoader` configuration validation to detect duplicate keys at all parameter levels, ensuring comprehensive nested key checking.
## Bug fixes and other changes
* Fixed bug where using dataset factories breaks with `ThreadRunner`.
* Made credentials loading consistent between `KedroContext._get_catalog()` and `resolve_patterns` so that both us
e `_get_config_credentials()`

## Breaking changes to the API
* Removed `ShelveStore` to address a security vulnerability.
Expand All @@ -18,6 +20,7 @@
## Community contributions
* [Puneet](https://github.com/puneeter)
* [ethanknights](https://github.com/ethanknights)
* [MigQ2](https://github.com/MigQ2)

# Release 0.19.8

Expand Down
2 changes: 1 addition & 1 deletion kedro/framework/cli/catalog.py
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ def resolve_patterns(metadata: ProjectMetadata, env: str) -> None:
context = session.load_context()

catalog_config = context.config_loader["catalog"]
credentials_config = context.config_loader.get("credentials", None)
credentials_config = context._get_config_credentials()
data_catalog = DataCatalog.from_config(
catalog=catalog_config, credentials=credentials_config
)
Expand Down

0 comments on commit 810a538

Please sign in to comment.