From 810a538ae5775f4dd40e697a54224763460c6cb1 Mon Sep 17 00:00:00 2001 From: Miguel Rodriguez Gutierrez Date: Sun, 15 Sep 2024 10:27:44 -0600 Subject: [PATCH] Use _get_config_credentials() in catalog CLI Update RELEASE.md Signed-off-by: Miguel Rodriguez Gutierrez --- RELEASE.md | 3 +++ kedro/framework/cli/catalog.py | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/RELEASE.md b/RELEASE.md index 548b49a109..8f0cf83afe 100644 --- a/RELEASE.md +++ b/RELEASE.md @@ -7,6 +7,8 @@ * Enhanced `OmegaConfigLoader` configuration validation to detect duplicate keys at all parameter levels, ensuring comprehensive nested key checking. ## Bug fixes and other changes * Fixed bug where using dataset factories breaks with `ThreadRunner`. +* Made credentials loading consistent between `KedroContext._get_catalog()` and `resolve_patterns` so that both us +e `_get_config_credentials()` ## Breaking changes to the API * Removed `ShelveStore` to address a security vulnerability. @@ -18,6 +20,7 @@ ## Community contributions * [Puneet](https://github.com/puneeter) * [ethanknights](https://github.com/ethanknights) +* [MigQ2](https://github.com/MigQ2) # Release 0.19.8 diff --git a/kedro/framework/cli/catalog.py b/kedro/framework/cli/catalog.py index 7bd0197e5b..c1a485b74a 100644 --- a/kedro/framework/cli/catalog.py +++ b/kedro/framework/cli/catalog.py @@ -227,7 +227,7 @@ def resolve_patterns(metadata: ProjectMetadata, env: str) -> None: context = session.load_context() catalog_config = context.config_loader["catalog"] - credentials_config = context.config_loader.get("credentials", None) + credentials_config = context._get_config_credentials() data_catalog = DataCatalog.from_config( catalog=catalog_config, credentials=credentials_config )