-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the LIFO order in which hooks are executed in settings.py
#1940
Comments
Also, while we are modifying hooks documentation, we need to take another look at the work involved with #978 |
Potentially overlapping with #1718, or that one should be a parent issue of this one. |
settings.py
settings.py
settings.py
Agree with @astrojuanlu. #1718 is a larger task, we can keep the scope for this one small. Simply document about the LIFO order. It's not the full picture of how hooks are executed yet. I have updated the description to reflect that. |
OK, let's do this. @noklam do you want to pick up the first draft of this in the upcoming sprint w/c 4th September? If so, please let @merelcht know to assign it to you within the sprint. Otherwise will keep an eye out for this to come next sprint if you are already maxed out with upcoming hack days & values day. |
That should be fine! I am fairly familiar with the hooks stuff so it shouldn't be too much work. |
I've bumped the estimate from 3 -> 5. See #3013 for more details (The PR will be only documentation change). There will be follow up PR but basically I found that there are extra documentation and development work that we should do. |
Description
We mention that hook implementations registered in
settings.py
run in LIFO order and that auto discovered hooks run before hooks insettings.py
.settings.py
template file to explain the run order of hooksThe text was updated successfully, but these errors were encountered: