Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setup.cfg from docs and starters #2767

Closed
noklam opened this issue Jul 5, 2023 · 3 comments
Closed

Remove setup.cfg from docs and starters #2767

noklam opened this issue Jul 5, 2023 · 3 comments

Comments

@noklam
Copy link
Contributor

noklam commented Jul 5, 2023 •
edited by merelcht
Loading

Description

We should remove setup.cfg from docs and starters, but I will do it in a separate PR as this may requires some more discussion and I don't want it to block this PR. The only reason we need setup.cfg is pytest and flake8. Both of them can be configured with pyproject.toml which is what we recommended.

Follow up of #2634

Thanks to the migration of pyproject.toml, I think we can finally kill setup.cfg in kedro project.

Remove mentions of setup.cfg

  • kedro templates and starters
  • kedro's doc
  • kedro.org
@astrojuanlu
Copy link
Member

Note that flake8 cannot be configured in pyproject.toml PyCQA/flake8#234

We could move away from it already in favor of ruff, or move its config to .flake8 as I proposed in #2853

@noklam
Copy link
Contributor Author

noklam commented Jul 31, 2023

If we move the recommendation to Ruff then we don't need flake8

@github-actions github-actions bot mentioned this issue Aug 18, 2023
Closed
@merelcht
Copy link
Member

This is already done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Kedro Framework
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@astrojuanlu @noklam @merelcht