Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kedro pipeline create to match starters template for tests #3614

Closed
ankatiyar opened this issue Feb 12, 2024 · 2 comments · Fixed by #3731
Closed

Update kedro pipeline create to match starters template for tests #3614

ankatiyar opened this issue Feb 12, 2024 · 2 comments · Fixed by #3731
Assignees
Labels
Issue: Bug Report 🐞 Bug that needs to be fixed

Comments

@ankatiyar
Copy link
Contributor

Description

The pipeline tests in the starters are in <project_root>/tests/pipelines> and when you create a new pipeline using the kedro pipeline create, the test files are created in src/tests/pipelines`.

Context

For eg - the project was created with spaceflights-pandas starter and pipeline2 and pipeline3 were created with kedro pipeline create and this is the resulting project structure -
Screenshot 2024-02-12 at 11 51 20

Expected Result

Quoting @astrojuanlu -

in my opinion we should put them under <project_root>/tests, and avoid shipping them. that was the spirit of the template rework at least, probably we forgot to update kedro pipeline create accordingly

@ankatiyar ankatiyar added the Issue: Bug Report 🐞 Bug that needs to be fixed label Feb 12, 2024
@astrojuanlu
Copy link
Member

tests was moved out of src in #2926

@julnow
Copy link

julnow commented Mar 20, 2024

I think it should be updated accordingly in docs, for example here: https://docs.kedro.org/en/stable/development/automated_testing.html#set-up-automated-testing-with-pytest
It still shows the old structure, so with tests under src directory.

@lrcouto lrcouto linked a pull request Mar 27, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug Report 🐞 Bug that needs to be fixed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants