You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The user use the above hook and find run_params result in {}, this has nothing to do with the default value. If we change run_params=123, the hook will print 123 instead. In pluggy documentation it never use keyword arguments, but also didn't explicitly said this is not allowed.
I checked the implementation and don't immediate understand why keywords is not possible, so it could be either a bug or intentional. I follow up in this issue:
Github: pytest-dev/pluggy#522
The text was updated successfully, but these errors were encountered:
I put this as a community ticket as there is no immediate action we can do. If pluggy confirm this is expected, maybe we can add some documents on our side to make this obvious.
Description
An user struggle with using
before_pipeline_run
hook, upon investigation I think the root cause is inpluggy
.Slack archive: https://linen-slack.kedro.org/t/22922543/hi-all-i-have-a-profiling-hook-that-uses-the-before-pipeline#42b185d3-2eca-445b-80f7-514b35bd6d12
The user use the above hook and find
run_params
result in{}
, this has nothing to do with the default value. If we changerun_params=123
, the hook will print123
instead. In pluggy documentation it never use keyword arguments, but also didn't explicitly said this is not allowed.I checked the implementation and don't immediate understand why keywords is not possible, so it could be either a bug or intentional. I follow up in this issue:
Github: pytest-dev/pluggy#522
The text was updated successfully, but these errors were encountered: