Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataset factories #2635

Merged
merged 29 commits into from
Jul 6, 2023
Merged

Dataset factories #2635

merged 29 commits into from
Jul 6, 2023

Commits on May 22, 2023

  1. Cleaned up and up to date version of dataset factories code 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed May 22, 2023
    Configuration menu
    Copy the full SHA
    ec66a12 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Add some simple tests 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed May 23, 2023
    Configuration menu
    Copy the full SHA
    5e6c15d View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Add parsing rules 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    0fca72c View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Refactor 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    06ed1a4 View commit details
    Browse the repository at this point in the history

  2. Add some tests 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    b0e3fb9 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Add unit tests 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    0833af2 View commit details
    Browse the repository at this point in the history

  2. Fix test + refactor runner 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    8fc80f9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feature/dataset-factories-for-catalog

    @ankatiyar
    ankatiyar authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    091f794 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Add comments + update specificity fn 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    8c192ee View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Update function names 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    3e2642c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/dataset-factories-for-catalog

    @ankatiyar
    ankatiyar authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    c2635d0 View commit details
    Browse the repository at this point in the history

  3. Update test 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    d310486 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. Merge branch 'main' into feature/dataset-factories-for-catalog

    @ankatiyar
    ankatiyar authored Jun 19, 2023
    Configuration menu
    Copy the full SHA
    573c67f View commit details
    Browse the repository at this point in the history

  2. Release notes + update resume scenario fix 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    9d80de4 View commit details
    Browse the repository at this point in the history

  3. revert change to suggest resume scenario 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    549823f View commit details
    Browse the repository at this point in the history

  4. Update tests DataSet->Dataset 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    e052ae6 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Small refactor + move parsing rules to a new fn 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    96c219f View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Fix problem with load_version + refactor 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    c2634e5 View commit details
    Browse the repository at this point in the history

  2. linting + small fix _get_datasets 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    eee606a View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. Remove check for existence 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    635510a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/dataset-factories-for-catalog

    @ankatiyar
    ankatiyar authored Jul 4, 2023
    Configuration menu
    Copy the full SHA
    394f37b View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Add updated tests + Release notes 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    a1c602d View commit details
    Browse the repository at this point in the history

  2. change classmethod to staticmethod for _match_patterns 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    978d0a5 View commit details
    Browse the repository at this point in the history

  3. Add test for layer 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    b4fe7a7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feature/dataset-factories-for-catalog

    @ankatiyar
    ankatiyar authored Jul 5, 2023
    Configuration menu
    Copy the full SHA
    2782dca View commit details
    Browse the repository at this point in the history

  5. Minor change from code review 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    85d3df1 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Remove type conversion 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    8904ce3 View commit details
    Browse the repository at this point in the history

  2. Add warning for catch-all patterns [dataset factories] (#2774) 

    * Add warning for catch-all patterns

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>

* Update warning message

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>

---------

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    bdc953d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feature/dataset-factories-for-catalog

    @ankatiyar
    ankatiyar authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    fa6c256 View commit details
    Browse the repository at this point in the history