Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pip-compile workflow to Github Actions #2846

Merged
merged 5 commits into from
Jul 27, 2023
Merged

Add pip-compile workflow to Github Actions #2846

merged 5 commits into from
Jul 27, 2023

Conversation

ankatiyar
Copy link
Contributor

@ankatiyar ankatiyar commented Jul 26, 2023 •
edited
Loading

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Continuing the move to Github Actions - also port the pip-compile tests for linux + windows.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@ankatiyar
Add pip compile step
66dcd93 
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
@ankatiyar
Update pip compile step
67f4bf1 
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
@ankatiyar ankatiyar marked this pull request as ready for review July 27, 2023 09:58
@ankatiyar ankatiyar requested a review from merelcht as a code owner July 27, 2023 09:58
@ankatiyar ankatiyar changed the title Add pip compile step Add pip-compile workflow to Github Actions Jul 27, 2023
astrojuanlu
astrojuanlu approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏽

What's the plan for the CircleCI jobs? I recall a comment yesterday somewhere but can't find it

@ankatiyar
Copy link
Contributor Author

Looks good to me 👍🏽

What's the plan for the CircleCI jobs? I recall a comment yesterday somewhere but can't find it

@astrojuanlu I've added the develop branch to the workflows here as well.
I think we're planning to keep the CircleCI jobs running for a while and then remove them after everything is ported and running smoothly like we did for kedro-plugins.

merelcht
merelcht approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

SajidAlamQB
SajidAlamQB approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ankatiyar!

@ankatiyar ankatiyar enabled auto-merge (squash) July 27, 2023 10:23
@ankatiyar ankatiyar merged commit 4fc3529 into main Jul 27, 2023
28 of 29 checks passed
@ankatiyar ankatiyar deleted the GA-add-pip-compile branch July 27, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrojuanlu astrojuanlu astrojuanlu approved these changes

@merelcht merelcht merelcht approved these changes

@SajidAlamQB SajidAlamQB SajidAlamQB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ankatiyar @astrojuanlu @merelcht @SajidAlamQB