Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DON'T MERGE] - Validate hooks impl #2863

Closed
wants to merge 2 commits into from
Closed

[DON'T MERGE] - Validate hooks impl #2863

wants to merge 2 commits into from

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Jul 30, 2023

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

(This is not a full implementation but a quick PoC, anyone who pick up this should continue to develop to fully address #2862)

See https://pluggy.readthedocs.io/en/stable/api_reference.html#pluggy.PluginManager.check_pending

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
@noklam noklam requested a review from merelcht as a code owner July 30, 2023 17:56
@noklam noklam marked this pull request as draft July 30, 2023 18:06
@noklam noklam changed the title Validate hooks impl [DON'T MERGE] - Validate hooks impl Jul 30, 2023
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
@noklam
Copy link
Contributor Author

noklam commented Nov 7, 2023

Closed as not finished - the PR is functional but need some proper unit tests.

@noklam noklam closed this Nov 7, 2023
@merelcht merelcht deleted the feat/validate-hook branch November 21, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant