Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kedro catalog resolve command #2891
Add kedro catalog resolve command #2891
Changes from 27 commits
1a81700
0f5b79f
b70f8e6
868671e
c3aec4c
2f956da
38a0394
04dc325
c30c565
1df1c3d
5758060
473ddf1
1e387d4
e88f695
96b84de
dd3117c
97d85ee
ac2cfc4
92d588f
09339c3
3fac8b3
7d7036f
7caa1af
271236c
c19707d
8784a37
259c5e5
779a286
6041ea5
3dec9f4
b026bfe
64366c8
a10feee
f3884df
365d1d5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit confusing that these variables have the exact name. In general it is best practice not to use the same variable as input and reassign the value in the same step. Maybe the second
catalog_config
can be re-named toexplicit_dataset
. That's what's stored there right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! Changed in 779a286
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean with "config_with_overwrite"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this context this means a catalog configuration where one of the explicit entries in the catalog also matches a pattern in the catalog, and the test is ensuring the explicit entry is not overwritten. Perhaps
fake_catalog_config_with_overwritable_dataset()
could be more intuitive? Orfake_catalog_config_with_resolvable_dataset()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
fake_catalog_config_with_resolvable_dataset
makes more sense to me.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To demonstrate the right datasets are included in output it might be worth adding two more asserts for
iris_data
andintermediate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in 3dec9f4