Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setuptools dependency #3437

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Remove setuptools dependency #3437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cfdfc11
Remove setuptools
DimedS Dec 20, 2023
6e54a89
Fix elen name
DimedS Dec 21, 2023
56af5c1
Update release.md
DimedS Dec 21, 2023
5326d7e
Merge branch 'main' into 2350-remove-setuptools
DimedS Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
## Bug fixes and other changes
* Removed example pipeline requirements when examples are not selected in `tools`.
* Allowed modern versions of JupyterLab and Jupyter Notebooks.
* Removed setuptools dependency

Check warning on line 8 in RELEASE.md

View workflow job for this annotation

GitHub Actions / vale

[vale] RELEASE.md#L8 

[Kedro.Spellings] Did you really mean 'setuptools'?
Raw output 
{"message": "[Kedro.Spellings] Did you really mean 'setuptools'?", "location": {"path": "RELEASE.md", "range": {"start": {"line": 8, "column": 11}}}, "severity": "WARNING"}

## Breaking changes to the API
* Added logging about not using async mode in `SequentiallRunner` and `ParallelRunner`.
Expand Down
9 changes: 5 additions & 4 deletions kedro/framework/cli/micropkg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
from rope.contrib import generate
from rope.refactor.move import MoveModule
from rope.refactor.rename import Rename
from setuptools.discovery import FlatLayoutPackageFinder

from build.util import project_wheel_metadata
from kedro.framework.cli.pipeline import (
Expand Down Expand Up @@ -227,9 +226,11 @@ def _pull_package( # noqa: PLR0913
# However, the rest of the code expects the non-normalized package name,
# so we have to find it.
packages = [
package
for package in FlatLayoutPackageFinder().find(project_root_dir)
if "." not in package
project_item.name
for project_item in project_root_dir.iterdir()
if project_item.is_dir()
and project_item.name != "tests"
and (project_item / "__init__.py").exists()
]
if len(packages) != 1:
# Should not happen if user is calling `micropkg pull`
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ dependencies = [
"PyYAML>=4.2,<7.0",
"rich>=12.0,<14.0",
"rope>=0.21,<2.0", # subject to LGPLv3 license
"setuptools>=65.5.1",
"toml>=0.10.0",
"toposort>=1.5", # Needs to be at least 1.5 to be able to raise CircularDependencyError
]
Expand Down