Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder the load_node docs to make requirement clear. #4065

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Aug 5, 2024

Description

Fix # #3643

Development notes

The issue mentions that we should add ipylab into the documentation. We already have it, but I guess we could make this clearer by moving the requirements to the top of the section.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam noklam enabled auto-merge (squash) August 6, 2024 13:55
@merelcht merelcht requested review from merelcht and removed request for yetudada August 6, 2024 14:06
@noklam noklam requested review from ElenaKhaustova and removed request for astrojuanlu and DimedS August 13, 2024 09:33
@noklam noklam requested a review from ankatiyar August 14, 2024 22:18
@noklam noklam merged commit bd68b86 into main Aug 16, 2024
10 checks passed
@noklam noklam deleted the noklam/ipylab-doc branch August 16, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants