-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixe using ThreadRunner
with dataset factories
#4093
Merged
ElenaKhaustova
merged 25 commits into
main
from
fix/4007-thread-runner-with-dataset-factories
Aug 29, 2024
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
d38b731
Added lock for dataset load
ElenaKhaustova 711f82c
Merge branch 'main' into fix/4007-thread-runner-with-dataset-factories
ElenaKhaustova 5a7642f
Merge branch 'main' into fix/4007-thread-runner-with-dataset-factories
ElenaKhaustova 6bc06a8
Replaced multiprocessing lock with multithreading
ElenaKhaustova 0ca6689
Merge branch 'main' into fix/4007-thread-runner-with-dataset-factories
ElenaKhaustova 66ded79
Added an alternative solution
ElenaKhaustova a44b078
Merge branch 'main' into fix/4007-thread-runner-with-dataset-factories
ElenaKhaustova f9df584
Merge branch 'main' into fix/4007-thread-runner-with-dataset-factories
ElenaKhaustova 219df08
Merge branch 'main' into fix/4007-thread-runner-with-dataset-factories
ElenaKhaustova 99f2da2
Updated solution 2
ElenaKhaustova ffe17d3
Made solution 1 main
ElenaKhaustova 61bafca
Removed solution 2
ElenaKhaustova ac9621a
Updated release notes
ElenaKhaustova 669e930
Merge branch 'main' into fix/4007-thread-runner-with-dataset-factories
ElenaKhaustova d4f6dc1
Merge branch 'main' into fix/4007-thread-runner-with-dataset-factories
ElenaKhaustova 80404bf
Removed lock solution
ElenaKhaustova a022445
Returned solution with patterns resolving
ElenaKhaustova 0ee3330
Added test for ThreadRunner
ElenaKhaustova 0ba5eed
Merge branch 'fix/4007-thread-runner-with-dataset-factories-bu' into …
ElenaKhaustova 2173f2a
Added _match_pattern patching
ElenaKhaustova e303959
Fixed tests to satisfy required coverage
ElenaKhaustova a772800
Merge branch 'main' into fix/4007-thread-runner-with-dataset-factories
ElenaKhaustova e3770d3
Merge branch 'main' into fix/4007-thread-runner-with-dataset-factories
ElenaKhaustova ee8377e
Reverted heading for the release notes
ElenaKhaustova 4e0b290
Merge branch 'main' into fix/4007-thread-runner-with-dataset-factories
ElenaKhaustova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this test also verify that dataset factories are resolved? Or is it not possible to test that specifically because the behaviour is not deterministic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not test that because we mock all the calls to runner, pipelines, catalog, etc, as for the rest of the session tests. It only tests that when using
ThreadRunner
, we enter into the branches to resolve the patterns.The resolution logic is tested with the catalog tests, though it can be tested here. But for that, we'll have to properly initialise runner, pipelines, and catalog - which might be too complex given that the resolution logic is already tested separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Thanks for clarifying! 🙂